Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): getPlayheadTimeAsDate() differs from X-EXT-PROGRAM-DATE-TIME #6371

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Mar 27, 2024

Fixes #5939

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround labels Mar 27, 2024
@avelad avelad added this to the v5.0 milestone Mar 27, 2024
@avelad avelad force-pushed the getPlayheadTimeAsDate-hls branch 2 times, most recently from 236b7c2 to 0596d83 Compare March 27, 2024 09:12
@shaka-bot
Copy link
Collaborator

shaka-bot commented Mar 27, 2024

Incremental code coverage: 93.18%

lib/hls/hls_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 1, 2024 06:14
@avelad avelad merged commit c615cf4 into shaka-project:main Apr 2, 2024
16 checks passed
@avelad avelad deleted the getPlayheadTimeAsDate-hls branch April 2, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getPlayheadTimeAsDate() differs from program time (X-EXT-PROGRAM-DATE-TIME)
3 participants