Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Opus and AV1 detection in TS #6385

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Apr 1, 2024

This detection is necessary to be able to correctly detect whether a media playlist of HLS that has TS segments is compatible or not.

Example: https://raw.githubusercontent.com/obecny/hls-opus-testing/main/stream.m3u8 (media playlist with Opus)

@avelad avelad added type: bug Something isn't working correctly priority: P3 Useful but not urgent labels Apr 1, 2024
@avelad avelad added this to the v5.0 milestone Apr 1, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 11.36%

lib/util/ts_parser.js Outdated Show resolved Hide resolved
@avelad avelad requested a review from theodab April 2, 2024 07:04
@avelad avelad merged commit bc23fff into shaka-project:main Apr 2, 2024
15 of 16 checks passed
@avelad avelad deleted the ts-opus-av1 branch April 2, 2024 07:48
avelad added a commit that referenced this pull request Apr 8, 2024
This detection is necessary to be able to correctly detect whether a
media playlist of HLS that has TS segments is compatible or not.

Example:
https://raw.githubusercontent.com/obecny/hls-opus-testing/main/stream.m3u8
(media playlist with Opus)
avelad added a commit that referenced this pull request Apr 8, 2024
This detection is necessary to be able to correctly detect whether a
media playlist of HLS that has TS segments is compatible or not.

Example:
https://raw.githubusercontent.com/obecny/hls-opus-testing/main/stream.m3u8
(media playlist with Opus)
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 1, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants