test: Remove bogus MediaSourceEngine test case #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MediaSourceEngine does not, in fact, preserve SourceBuffer properties when we reset it to switch codecs. This is handled by StreamingEngine instead, through a follow-up call to setStreamProperties. The test only ever passed as originally written because there was a missing `await` on an async reset process. This removes the bogus test. Related to shaka-project#6458, shaka-project#6462
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo and
theodab
avelad
approved these changes
Apr 22, 2024
avelad
added
the
component: tests
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
MediaSourceEngine does not, in fact, preserve SourceBuffer properties when we reset it to switch codecs. This is handled by StreamingEngine instead, through a follow-up call to setStreamProperties. The test only ever passed as originally written because there was a missing `await` on an async reset process. This removes the bogus test. Related to #6458, #6462
joeyparrish
added a commit
that referenced
this pull request
May 7, 2024
MediaSourceEngine does not, in fact, preserve SourceBuffer properties when we reset it to switch codecs. This is handled by StreamingEngine instead, through a follow-up call to setStreamProperties. The test only ever passed as originally written because there was a missing `await` on an async reset process. This removes the bogus test. Related to #6458, #6462
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaSourceEngine does not, in fact, preserve SourceBuffer properties when we reset it to switch codecs. This is handled by StreamingEngine instead, through a follow-up call to setStreamProperties.
The test only ever passed as originally written because there was a missing
awaiton an async reset process.This removes the bogus test.
Related to #6458, #6462