test: Fix test failure waiting for passed time #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some rare cases, particularly on Fuchsia-based Chromecasts at the moment, I am seeing test failures where the test is waiting for a time that has already passed. It appears that the `timeupdate` events may be missed in some cases. The `currentTime` appears to be less than the target at the last `timeupdate` event, then the time progresses internally, then a buffering state is hit and no new `timeupdate` events fire. So the Waiter class should use a timer for this as it does for many other types of waits.
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
May 11, 2024
theodab
approved these changes
May 11, 2024
avelad
pushed a commit
that referenced
this pull request
May 13, 2024
In some rare cases, particularly on Fuchsia-based Chromecasts at the moment, I am seeing test failures where the test is waiting for a time that has already passed. It appears that the `timeupdate` events may be missed in some cases. The `currentTime` appears to be less than the target at the last `timeupdate` event, then the time progresses internally, then a buffering state is hit and no new `timeupdate` events fire. So the Waiter class should use a timer for this as it does for many other types of waits.
joeyparrish
added a commit
that referenced
this pull request
May 31, 2024
In some rare cases, particularly on Fuchsia-based Chromecasts at the moment, I am seeing test failures where the test is waiting for a time that has already passed. It appears that the `timeupdate` events may be missed in some cases. The `currentTime` appears to be less than the target at the last `timeupdate` event, then the time progresses internally, then a buffering state is hit and no new `timeupdate` events fire. So the Waiter class should use a timer for this as it does for many other types of waits.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases, particularly on Fuchsia-based Chromecasts at the moment, I am seeing test failures where the test is waiting for a time that has already passed. It appears that the
timeupdateevents may be missed in some cases. ThecurrentTimeappears to be less than the target at the lasttimeupdateevent, then the time progresses internally, then a buffering state is hit and no newtimeupdateevents fire. So the Waiter class should use a timer for this as it does for many other types of waits.