Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HLS): Fix mimetype checking when using SUPPLEMENTAL-CODECS #6592

Closed
wants to merge 1 commit into from
Closed

fix(HLS): Fix mimetype checking when using SUPPLEMENTAL-CODECS #6592

wants to merge 1 commit into from

Conversation

mgny
Copy link
Contributor

@mgny mgny commented May 13, 2024 •
edited by avelad
Loading

Fixes #6586

@google-cla Google CLA
Copy link

google-cla bot commented May 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels May 13, 2024
@avelad avelad added this to the v4.9 milestone May 13, 2024
@avelad avelad changed the title fix the typo in declaration of const type fix(HLS): Get the correct mimetype when using SUPPLEMENTAL-CODECS May 13, 2024
@avelad avelad changed the title fix(HLS): Get the correct mimetype when using SUPPLEMENTAL-CODECS fix(HLS): Fix mimetype checking when using SUPPLEMENTAL-CODECS May 13, 2024
@avelad
Copy link
Collaborator

avelad commented May 13, 2024

@mgny LGTM, can you sign the CLA? Thanks!

@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

@mgny
Copy link
Contributor Author

mgny commented May 13, 2024

@mgny LGTM, can you sign the CLA? Thanks!

I signed the CLA with my individual account, but I realised that I committed with wrong author information. Sorry for that. Should I close this PR and create another with correct author info?

@avelad
Copy link
Collaborator

avelad commented May 13, 2024

@mgny LGTM, can you sign the CLA? Thanks!

I signed the CLA with my individual account, but I realised that I committed with wrong author information. Sorry for that. Should I close this PR and create another with correct author info?

Yes, the CLA has to be signed with the same email that appears in the commit. So it is best that you create a new commit with the correct information.

@mgny mgny closed this May 13, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 12, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

Bug in HLS SUPPLEMENTAL-CODECS support
3 participants
@mgny @avelad @shaka-bot