fix(HLS): Support request byterange on media playlist detection #6629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
|
Incremental code coverage: 100.00% |
theodab
approved these changes
May 17, 2024
| const middleSegmentIdx = Math.trunc((playlist.segments.length - 1) / 2); | ||
| const middleSegment = playlist.segments[middleSegmentIdx]; | ||
| const middleSegmentUris = shaka.hls.Utils.constructSegmentUris( | ||
| const firstSegment = playlist.segments[0]; |
There was a problem hiding this comment.
The change in which we started looking for a segment in the middle of the playlist, instead of the first one, was originally written by you.
In all honesty I don't remember why we were doing it before. I suppose I'll have to take your word that it is no longer necessary.
There was a problem hiding this comment.
It's not really necessary anymore and it also causes problems with byterange (we would have to look at all the previous segments to calculate the range).
avelad
added a commit
that referenced
this pull request
May 17, 2024
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6627