test: Upgrade Karma to fork with additional fixes #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only fix right now is a minor one: joeyparrish/karma@d98765e With the message: > fix: Fix message event exception > > Message events may not have an origin, and they may not have an > originalEvent field. This happens in particular when loading Karma > and the Chromecast SDK on a Chromecast. An event arrives from the > platform with neither of these properties. > > This fixes the error by checking for originalEvent before accessing > a property of it. To see a diff of all current fixes at any time, see: karma-runner/karma@master...joeyparrish:karma:shaka-fixes
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
avelad
approved these changes
May 18, 2024
|
Incremental code coverage: No instrumented code was changed. |
theodab
approved these changes
May 18, 2024
avelad
pushed a commit
that referenced
this pull request
May 27, 2024
The only fix right now is a minor one: joeyparrish/karma@d98765e With the message: > fix: Fix message event exception > > Message events may not have an origin, and they may not have an > originalEvent field. This happens in particular when loading Karma > and the Chromecast SDK on a Chromecast. An event arrives from the > platform with neither of these properties. > > This fixes the error by checking for originalEvent before accessing > a property of it. To see a diff of all current fixes at any time, see: karma-runner/karma@master...joeyparrish:karma:shaka-fixes
joeyparrish
added a commit
that referenced
this pull request
May 31, 2024
The only fix right now is a minor one: joeyparrish/karma@d98765e With the message: > fix: Fix message event exception > > Message events may not have an origin, and they may not have an > originalEvent field. This happens in particular when loading Karma > and the Chromecast SDK on a Chromecast. An event arrives from the > platform with neither of these properties. > > This fixes the error by checking for originalEvent before accessing > a property of it. To see a diff of all current fixes at any time, see: karma-runner/karma@master...joeyparrish:karma:shaka-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only fix right now is a minor one:
joeyparrish/karma@d98765e
With the message:
To see a diff of all current fixes at any time, see:
karma-runner/karma@master...joeyparrish:karma:shaka-fixes