test: Bypass log settings for support dump #6654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karma creates a dump() function on the context window that we can use to log something to the console without respect for the normal captureConsole setting. Use this for the output of probeSupport(), so we always have it in CI logs.
joeyparrish
requested review from
littlespex,
alekzz,
avelad,
JulianDomingo and
theodab
alekzz
approved these changes
May 22, 2024
There was a problem hiding this comment.
Does it work for every browser? I see only Firefox support here https://developer.mozilla.org/en-US/docs/Web/API/Window/dump.
Yes, because it doesn't use that, it uses a conflictingly-named method created at runtime by Karma: contextWindow.dump = function () {
self.log('dump', arguments)
}In the flattened environment, there is only one window within Karma, so contextWindow == window. |
|
You can see the results already in the CI logs for this PR: https://github.com/shaka-project/shaka-player/actions/runs/9198874232/job/25302574461?pr=6654 |
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
added a commit
that referenced
this pull request
May 31, 2024
Karma creates a dump() function on the context window that we can use to log something to the console without respect for the normal captureConsole setting. Use this for the output of probeSupport(), so we always have it in CI logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Karma creates a dump() function on the context window that we can use to log something to the console without respect for the normal captureConsole setting. Use this for the output of probeSupport(), so we always have it in CI logs.