Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Add averageLoadTime and errors to ad stats #6828

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 14, 2024

No description provided.

@avelad avelad marked this pull request as draft June 14, 2024 11:30
@avelad
Copy link
Collaborator Author

avelad commented Jun 14, 2024

This PR needs to be merged first #6827

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Jun 14, 2024
@avelad avelad added this to the v4.10 milestone Jun 14, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 14, 2024

Incremental code coverage: 50.00%

# Conflicts:
#	ui/ad_statistics_button.js
#	ui/ui.js
@avelad avelad marked this pull request as ready for review June 17, 2024 08:52
@avelad avelad merged commit 037d4cb into shaka-project:main Jun 18, 2024
17 of 21 checks passed
@avelad avelad deleted the ad-statistics branch June 19, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants