-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DASH): Ensure variants are created for unique video codec bases #6835
Open
willdharris
wants to merge
7
commits into
shaka-project:main
Choose a base branch
from
cbsinteractive:issue/6820-mixed-codecs-missing-variants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94
−2
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d085a3f
Keep matched stream of diff codec tag unused
willdharris 48cde01
Revert variable move
willdharris b2dc800
Update stream match test
willdharris af10bae
Update comment
willdharris b870d2d
Update email
willdharris 7727f7f
Create stream per unique audio codec
willdharris fa0f119
Add audio stream per codec test
willdharris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be misunderstanding, but it seems like the solution could be just to normalize video codecs in streams before processing periods and in configs before applying preferences. If they all said hev or all said hvc, problem solved, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That could work, but I think would still result in confusion in some cases, like we are finding with manifests returned from Google DAI.
For example, we have HEVC content encoded in a
hvc
format. When requesting a stitched manifest from DAI, with DAI pre-rolls and our original content, the HEVC pre-roll representations from DAI are encoding in ahev
format. As a content owner, I know there arehvc
representations in my manifest but may not know DAI has used a different format for pre-rolls. If Shaka Player "converts"hvc
tohev
, then when nohvc
variants exist it's confusing as to why those aren't available.Outside the scope of this change but related: In the same manifest we also have content encoded as
dvhe
. DAI does not encode ads in DVHE. Shaka Player matches the content perioddvhe
streams with the pre-rollhev
streams.dvhe
variants are still created even though DVHE streams aren't available in pre-rolls. For conformity with that behavior, I think it makes sense to create unique variants for each codec base.@dsparacio Any additional thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going on leave, so @theodab and @avelad should make a decision about this without waiting for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we go in the direction @joeyparrish suggested? I guess it would help in majority of cases. I'm afraid with the proposed solution we might end up with plenty of almost-duplicated variants and it can be confusing for devs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! @theodab what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts on this.
My main concern is the difference with HVC and DVHE when mixed with HEV from DAI content.
As Will pointed out, currently, if we set preferredVideoCodec to [hev, hvc] we get a bitrate ladder with 14 reps instead of 7 and need to filter, but all are marked as HEV even though some are HVC.
When I use preferredVideoCodec[hev, dvhe] I get same as aboven and it excludes DVHE altogether.
When I use preferredVideoCodec[dvhe] I get exactly what I am expecting, 7 bitrates all DVHE representations.
So as a user, I would expect that using preferredVideoCodec[hvc] would result the same as preferredVideoCodec[dvhe]. However it only returns 3 items due to the issue we pointed out in the ticket.
It does seem it would be more efficient to do this the way Joey suggested. I just want to make sure we have some consistency in the properties settings and expected results.
Meaning either works for us.... but its odd if they are different IMHO
Or
Currently api settings