feat: Dynamic target latency #6858
Open
+148
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR supercedes #6193. I marked it as a draft because while the functionality is there and the build passes locally, I hadn't yet gotten a chance to confirm that it's working as intended. It's possible there may be tweaks necessary. I'll get back to it on Thursday. |
|
Incremental code coverage: 42.03% |
avelad
added
type: enhancement
|
@gkatsev please fix the tests! Thanks! |
|
I'll take a look. At first glance they seemed unrelated, but who knows. |
…, it ends up being a bit over 6000
gkatsev
force-pushed
the
dynamic-target-latency-2
branch
from
c9d3042
to
ff2b547
Compare
gkatsev
commented
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new feature for adjusting the target latency closer to the live edge when playback is stable and back off away from the live edge when playback rebuffers. It is off by default and will only run a default of 5 times before it will stop trying to adjust the target latency.
Closes #6131.