Fix fullscreen polyfill for MSIE 11 #777
Conversation
Ross-cz
force-pushed
the
feature/fix-fullscreen-polyfill
branch
from
9f173d4
to
d718f2c
Compare
lib/polyfill/fullscreen.js
Outdated
| var newEvent; | ||
| if (typeof(Event) === 'function') { | ||
| newEvent = new Event(eventType, /** @type {EventInit} */(event)); | ||
| } else { |
There was a problem hiding this comment.
Please add a comment here that IE 11 does not have an Event constructor.
Ross-cz
force-pushed
the
feature/fix-fullscreen-polyfill
branch
from
d718f2c
to
c627b0a
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Ross-cz
force-pushed
the
feature/fix-fullscreen-polyfill
branch
from
c627b0a
to
50d92b8
Compare
|
CLAs look good, thanks! |
|
I'm going to run this through the build bot now, but we will also need to do a manual test in our lab to confirm. Thanks! |
|
Testing in progress... |
|
All tests passed! |
|
I have confirmed that fullscreen on IE 11 throws when it tries to proxy the event. The build bot ran the linter, compiler, and all the automated tests. Looks good to me! |
|
I just confirmed the fix, which led me to #787. Thanks for the PR! |
|
Cherry-picked to v2.1.1 and v2.0.9. |
github-actions
bot
added
the
status: archived
No description provided.