Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not use libaom options, prefer libsvt-av1 #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 0 additions & 19 deletions streamer/transcoder_node.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,25 +284,6 @@ def _encode_video(self, stream: VideoOutputStream, input: Input) -> List[str]:
# speeds up encoding, balancing against quality
'-speed', '2',
]
elif stream.codec == VideoCodec.AV1:
args += [
# According to graphs at https://bit.ly/2BmIVt6, this AV1 setting
# results in almost no reduction in quality (0.8%), but a significant
# boost in speed (20x).
'-cpu-used', '8',
# According to the wiki (https://trac.ffmpeg.org/wiki/Encode/AV1),
# this allows threaded encoding in AV1, which makes better use of CPU
# resources and speeds up encoding. This will be ignored by libaom
# before version 1.0.0-759-g90a15f4f2, and so there may be no benefit
# unless libaom and ffmpeg are built from source (as of Oct 2019).
'-row-mt', '1',
# According to the wiki (https://trac.ffmpeg.org/wiki/Encode/AV1),
# this allows for threaded _decoding_ in AV1, which will provide a
# smoother playback experience for the end user.
'-tiles', '2x2',
# AV1 is considered "experimental".
'-strict', 'experimental',
]

keyframe_interval = int(self._pipeline_config.segment_size *
input.frame_rate)
Expand Down