-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ac3 and ec3 #37 #69
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This looks good to me, but I have one question: On what did you base the bitrate choices for ac3 and ec3? |
@joeyparrish Hey they were recommended bitrates at FFmpeg site , so from there I took stereo values. |
I would like more to take the values that Apple gives for Reference in HLS. What do you think? |
@avelad, how about this: We adjust the defaults to be more similar to Apple's recommendations, and we also create a explicit bitrate config file that exactly matches what Apple suggests, including for video. Here's a compromise between our existing values (extrapolated from Google internal recommendations) and Apple's recommendations:
@avelad, @ans-negi, if y'all both agree, let's use the value above as the default. |
I agree! |
@joeyparrish Yeah that makes sense, I have updated the defaults. |
Thanks for your contribution! |
No description provided.