Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): probe whether the input exists or not #94

Merged
merged 5 commits into from
Sep 9, 2021
Merged

fix(errors): probe whether the input exists or not #94

merged 5 commits into from
Sep 9, 2021

Conversation

mariocynicys
Copy link
Collaborator

@mariocynicys mariocynicys commented Sep 9, 2021 •
edited
Loading

Probing with 'stream=index' should return the track_num if it existed, and an empty string if the input did not exist.
fixes #89

@mariocynicys mariocynicys changed the title fix(errors): probe whether the input existed or not fix(errors): probe whether the input exists or not Sep 9, 2021
joeyparrish
joeyparrish approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@joeyparrish joeyparrish merged commit 689b803 into shaka-project:master Sep 9, 2021
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need clear error message if audio input contains no audio
2 participants
@mariocynicys @joeyparrish