Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce rails dependency #1366

Closed
supremebeing7 opened this issue Mar 25, 2021 · 1 comment
Closed

Reduce rails dependency #1366

supremebeing7 opened this issue Mar 25, 2021 · 1 comment
Labels
enhancement

Comments

@supremebeing7
Copy link

It would be nice if this gem could depend only on the gems from rails it needs, rather than the full rails gem. I'm not sure what specific parts are needed without digging, but I'd guess something like railties, actionview, sprockets-rails?

The whole hoopla with mimemagic versions getting yanked and rails activestorage gem depending on it really shined a light on this type of thing.

I'm happy to help in some way, even posting a PR with some changes, though I don't have a ton of time to dig through the internals of this gem.
@justin808
Copy link
Member

@supremebeing7 Sure...PR would be great!

@Judahmeek Judahmeek closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justin808 @supremebeing7 @Judahmeek