Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run inside a Rails engine? #257

Closed
cberkom opened this issue Feb 7, 2016 · 3 comments
Closed

Run inside a Rails engine? #257

cberkom opened this issue Feb 7, 2016 · 3 comments

Comments

@cberkom
Copy link

cberkom commented Feb 7, 2016

We have a Rails app with several engines (marketing site, current app, etc). We would like to run our next-generation React app inside it's own engine. Is this possible using this library?

@justin808
Copy link
Member

@cberkom Any reason this wouldn't work?

I guess we could run into some issue regarding the server rendering, as we assume one bundle.

It would probably not be hard to make react_on_rails work with multiple rails engines.

Feel free to submit a PR and I'll give you a hand with any obstacles.

@luisrita
Copy link

@justin808 just managed to run react_on_rails on an engine but I had to make some adjustments in the engine ApplicationController as explained in this issue:

...we inherited from ::ApplicationController from the dummy app, no longer receive this error.

Not sure if this is correct way to solve this.

@justin808
Copy link
Member

@luisrita Maybe you can make a small example? The best would be to put the example in /spec/dummy-engine with a couple unit tests, and that way we'd cover this in our CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants