Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator option to specify first component name rather than hello_world #716

Closed
oklas opened this issue Feb 14, 2017 · 15 comments
Closed

Comments

@oklas
Copy link

oklas commented Feb 14, 2017

The command:

rails generate react_on_rails:install

create many things included HelloWorld component rails binding and view and so on.

In most cases (except demo) need not HelloWorld but need App or Bundle or MainPage or some practical useful name. It is need to rename about ten files and edit contents in some places. It is not difficult, but with this it will be not needed to do at all.

It may be command some like this:

rails generate react_on_rails:install --name App

It will be good to change default value instead of HelloWorld may be MainPage or App may be somebody has another name to suggest or opinion which name to prefer.

@justin808
Copy link
Member

@oklas Any chance that you can submit a PR for this? We've been planning on doing this for ages. It just hasn't been a blocker or priority. The community would ❤️ this!

@oklas
Copy link
Author

oklas commented Feb 15, 2017

I can not promise anything but will try to identify a gap in the boundless number of tasks.

@justin808
Copy link
Member

@oklas Thank you! I look forward to seeing what you get!

@justin808
Copy link
Member

@oklas Any word on this one?

@oklas
Copy link
Author

oklas commented Feb 28, 2017

Hi Justin! I have no time currently. But I want to improve it definitely but I can not promise.

@oklas
Copy link
Author

oklas commented Jun 2, 2017

Rename HelloWorld to MainPage (like this PR857) will be good step. You can imagine projects where there is MainPage. But it is unlikely that someone will want to have the HelloWorld in his power project. Therefore, each time everyone should rename several files and fix the code in them.

@ledestin
Copy link

ledestin commented Jun 7, 2017

Just to let you know I'm working on this feature.

@justin808
Copy link
Member

@ledestin Please be sure to see the details in https://github.com/shakacode/react_on_rails/blob/master/CONTRIBUTING.md and feel free to ping me when you're ready for review.

Most importantly, we'll want to add an option to the super awesome generator testing developed by @robwise.

@justin808
Copy link
Member

@ledestin is no longer working on this one. I'm open to somebody else picking this one up and creating a PR.

@justin808 justin808 changed the title Add cli key for specify first component name Add generator option to specify first component name rather than hello_world Apr 21, 2018
@rodrigobdz
Copy link
Contributor

@justin808 I'll grab this one.

@justin808
Copy link
Member

@rodrigobdz That would be awesome!

@justin808
Copy link
Member

@rodrigobdz Please email me justin@shakacode.com to get in our Slack group. Maybe we could do #1089 first.

@splashinn
Copy link

@justin808 is this still up for grabs?

@rodrigobdz
Copy link
Contributor

@splashinn It should be. I'm not working on this anymore.

@behraaang
Copy link

behraaang commented Jun 2, 2019

@justin808 Hello dear Justin, since this is more of a backend issue than front, I would like to take a try at this. For clarifying I need to know if you want to change just the component name or all files including controller layout namespace, etc.
P.S. I just filled out the google form for hiring process, hope you like my responses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants