Generator Appends Hello World Route to Other Engines

[robwise]

In the case where users have multiple engines in their routes file, the built-in Rails generator helper, route, will add the route to all of the engines. It should only be appending the route once.

I believe this is due to the helper's reliance on gsub and their use of routes.draw do instead of Rails.application.routes.draw do, since the former will result in false positives.

Relevant links:

• Rails route helper API
• Rails route helper source code I've linked directly to what I believe is the line, the definition of sentinel which uses a regex that is too loose
• Thor inject_into_file API (used by the route_helper)
• Thor inject_into_file source

[justin808]

This is not incredibly serious as we ask user to commit files before running the generator, and this can be manually fixed.

[robwise]

@justin808 true, it's borderline whether we should even fix this here, as it's really a bug with Rails's Generators::Helpers.route IMO