This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Feature/Rubocop #10
Merged
Feature/Rubocop #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref #3 Actually all rule statuses should be uppercased to be conformed with enumerable org.sonar.api.rule.RuleStatus
- Added required annotations - Fixed parsing `corrected` property of an offense - in some cases it is null - Updated readme with Rubocop mentions ref #3
ref #3 Before if the code base did not has the rubocop report file the analyzing process had been failed. This was a very unconvinient way to provide an additional ability for the end user. This commit changes this behaviour and of there is no report file the system skips rubocop sensor.
…to feature/rubocop
shakedlokits
requested review from
abraverm and
lyrch
and removed request for
lyrch and
abraverm
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged and rebased @sergio1990 Rubocop PR