Add MONGO-CR authentication support

[paulnues]

The following Pull Request includes code changes that will add MONGO-CR authentication support.

[paulnues]

Also, this PR makes config_port optional as pymongo will default to use port 27017 if a port number is not given.

[coveralls]

Coverage decreased (-1.97%) when pulling 19210c1 on paulnues:master into 1312e0d on shakefu:master.

[shakefu]

Is this line supposed to be in here? Or is it a leftover from testing?

[shakefu]

I'm a bit confused about the usage of humbledb.use_authentication - it seems redundant to the config_auth setting itself?

[paulnues]

It was more of a design choice because there was no way to avoid skipping
the test_auth.py unit test suite if Mongo authentication was turned off.
Mongo/Pymongo has no way of letting you know via a command that it has
auth turned on.

On Wed, Jun 18, 2014 at 4:18 PM, shakefu notifications@github.com wrote:

I'm a bit confused about the usage of humbledb.use_authentication - it
seems redundant to the config_auth setting itself?

—
Reply to this email directly or view it on GitHub
#4 (comment).

[image: Paul Nues on about.me]

Paul Nues
about.me/paul.nues
http://about.me/paul.nues

[shakefu]

Would it be possible to try to connect or perform an auth'd command in setup() in the test_auth suite and catch the exception? I think they give you an explicit "unauthorized" message, in the OperationFailure, IIRC.

[paulnues]

Also, I found it useful have an explicit configuration toggle for
authentication as I found it useful to add the code in first and then flip
a "main switch" to turn authentication at a later time when all the
Document models were ready with authentication pieces in place. It was a
decision based on current production needs more than anything else.

On Wed, Jun 18, 2014 at 4:27 PM, Paul N paul@team.about.me wrote:

It was more of a design choice because there was no way to avoid skipping
the test_auth.py unit test suite if Mongo authentication was turned off.
Mongo/Pymongo has no way of letting you know via a command that it has
auth turned on.

On Wed, Jun 18, 2014 at 4:18 PM, shakefu notifications@github.com wrote:

I'm a bit confused about the usage of humbledb.use_authentication - it
seems redundant to the config_auth setting itself?

—
Reply to this email directly or view it on GitHub
#4 (comment).

[image: Paul Nues on about.me]

Paul Nues
about.me/paul.nues
http://about.me/paul.nues

[image: Paul Nues on about.me]

Paul Nues
about.me/paul.nues
http://about.me/paul.nues

[shakefu]

In production we should be using a pyconfig.Setting for auth, which would just as easily flip to enable/disable auth:

config_auth = pyconfig.setting('db.site.config_auth', None)

Edit: Crappy pyconfig key name, but you get the idea.

[coveralls]

Coverage decreased (-1.18%) when pulling 6d0a4cb on paulnues:master into e1e6d4b on shakefu:master.

[coveralls]

Coverage decreased (-1.46%) when pulling b8bb2cf on paulnues:master into e1e6d4b on shakefu:master.

[shakefu]

Pretty sure this line should be:

if not cls.config_auth and not username and password:

[paulnues]

Hmm. What's there now should be right.

Most of the time, we will have a Document that does not have it's own
config_auth parameter. In this case, the username and password coming in
will be empty. If the username and password come in empty, then the
default Mongo.config_auth will be used. If no Mongo.config_auth was
declared from the beginning, then it's assumed that all database
connections won't be authenticated. All authenticate() calls will be
ignored.

On Thu, Jun 19, 2014 at 11:45 AM, shakefu notifications@github.com wrote:

In humbledb/mongo.py:

@@ -113,6 +121,38 @@ def reconnect(cls):
cls._connection.disconnect()
cls._connection = cls._new_connection()

• def authenticate(cls, database, username=None, password=None):

•    """ Delegates authentication to be the responsibility of the
  

•        context manager.
  

•        .. versionadded: 5.2.0
  

•    """
  

•    # Having no credentials makes this call a noop.
  

•    if not cls.config_auth:
  

Pretty sure this line should be:

if not cls.config_auth and not username and password:

—
Reply to this email directly or view it on GitHub
https://github.com/shakefu/humbledb/pull/4/files#r13985911.

[image: Paul Nues on about.me]

Paul Nues
about.me/paul.nues
http://about.me/paul.nues

[coveralls]

Coverage decreased (-1.46%) when pulling 7e52462 on paulnues:master into e1e6d4b on shakefu:master.

[paulnues]

Let's find a better solution for this.