Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore networks with a recent state change. #429

Merged
merged 4 commits into from Oct 20, 2020
Merged

Ignore networks with a recent state change. #429

merged 4 commits into from Oct 20, 2020

Conversation

mikalstill
Copy link
Collaborator

Hopefully fixes #428.

Copy link
Contributor

@mandoonandy mandoonandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is needed so that I can see the full db entry in the network
cleaner. Ultimately we should move to some sort of "persisted
object" base class which refreshes db_entry when the state of the
db changes.
Copy link
Contributor

@mandoonandy mandoonandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mandoonandy mandoonandy merged commit 6a1b630 into master Oct 20, 2020
@mikalstill mikalstill deleted the bug-428 branch October 31, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing phy interface in CI
2 participants