Update nginx config to set origin and hide allow origin from backends #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If any backend returns Access-Control-Allow-Origin we end up with a header with multiple values and that's not allowed or makes sense so we have to ensure we hide it. Also, we need to the origin to an actual domain in order to send credentials. Credentials are not allowed with wildcard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for the repo! I've just changed the origin from wildcard to $http_origin so it matches whatever comes through and allows setting 'Access-Control-Allow-Credentials' which doesn't work with wildcard origins. Also, I hide the origin header sent by the backend so it doesn't clash with what's happening here.