Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public client gives access to a pile of internals #21

Closed
kudrykv opened this issue Dec 14, 2019 · 1 comment
Closed

Public client gives access to a pile of internals #21

kudrykv opened this issue Dec 14, 2019 · 1 comment

Comments

@kudrykv
Copy link

kudrykv commented Dec 14, 2019

The public client gives access to methods of core and http.Client. Is this by design? And if so, what benefits are there in this approach?

The same relates to the personal client.

Screenshot 2019-12-14 at 17 28 50

@shal
Copy link
Owner

shal commented Mar 9, 2020

Hello @kudrykv!

You are right, this behavior is expected.

I'm not sure this library will be up to date all the time.
As far as I don't have any information about Monobank plans for their read-only API, I kept the ability to use http.Client directly.

If you have any better suggestions, please contact me: hi@shal.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants