Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move umd build to dist/atlaspack.js #11

Open
rymohr opened this issue Oct 26, 2015 · 1 comment
Open

Move umd build to dist/atlaspack.js #11

rymohr opened this issue Oct 26, 2015 · 1 comment

Comments

@rymohr
Copy link
Contributor

rymohr commented Oct 26, 2015

With ES6 adoption growing fast it's nice to have the original source. The current approach results in errors like the following in webpack:

WARNING in ~/atlaspack/index.js
Critical dependencies:
1:440-447 This seems to be a pre-built javascript file. Though this is possible, it's not recommended. Try to require the original source to get better results.
@ ~/atlaspack/index.js 1:440-447

May I suggest moving the umd build to dist/atlaspack.js instead?

Related to #8

@shama
Copy link
Owner

shama commented Oct 28, 2015

Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants