Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request/Response full support / Update README #92

Closed
Louis-PhilippeGentile opened this issue Mar 25, 2024 · 6 comments
Closed

Request/Response full support / Update README #92

Louis-PhilippeGentile opened this issue Mar 25, 2024 · 6 comments

Comments

@Louis-PhilippeGentile
Copy link

Louis-PhilippeGentile commented Mar 25, 2024

Hello,

The README at the root of the project mentions that

Flow control and Request/Response functionality is not fully supported.

However, when sifting through the documentation, I failed to find anything relating to the Request/Response feature of MQTT 5 that is not supported by this package.

Am I missing something, or is the README out of date?

@shamblett
Copy link
Owner

I think you are right, the client does support request/response in the connect and connect ack messages, the received connect ack message is stored in the connection state so the response information is available to the user . I'll update the README.

@MichalNemec
Copy link

I would like to ask as well about request response. Does not seem that publish implements response topic.

could that be implemented since its supported in mqtt5?
https://www.emqx.com/en/blog/mqtt5-request-response

@Louis-PhilippeGentile
Copy link
Author

I would like to ask as well about request response. Does not seem that publish implements response topic.

could that be implemented since its supported in mqtt5? https://www.emqx.com/en/blog/mqtt5-request-response

I believe it is implemented, or at least it is present in the documentation as part of the MqttPublishVariableHeader class as the responseTopic property.

The MqttPublishMessage also contains a method to directly set the responseTopic.

@MichalNemec
Copy link

Oh, i completely missed this, thank you for correcting me!

@alimcomp
Copy link

alimcomp commented May 5, 2024

Hi and thanks
When you are going to fix readme file?

@shamblett
Copy link
Owner

Done, package re published at version 4.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants