issue77: Fixed the invalid range error issue with the small matchee raw topic when compared with base raw topic length #78
Conversation
…aw topic when compared with base raw topic length
lib/src/mqtt_subscription_topic.dart
Outdated
| @@ -95,6 +95,13 @@ class MqttSubscriptionTopic extends MqttTopic { | |||
| return false; | |||
| } | |||
| } | |||
| // If we're at the last fragment of the matchee rawTopic but there are | |||
| // more fragments in the in the lhs rawTopic then the matchee rawTopic | |||
There was a problem hiding this comment.
Okay I'll fix it
|
Ok, the file mqtt_client_base_test.dart contains a group test ''Subscription Topic' to unit test this class, could you add a test/s to test your change please. |
Sure I'll check that |
|
Re released the package for issue 79, you will probably need to rebase. |
|
@shamblett I've updated the PR after rebase |
|
OK an existing unit test is now failing, could you have a look please, thanks. |
Okay I'll check it |
|
@shamblett PR updated and now all the test cases are working |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
- Coverage 61.23% 61.18% -0.06%
==========================================
Files 102 102
Lines 3555 3558 +3
==========================================
Hits 2177 2177
- Misses 1378 1381 +3 ☔ View full report in Codecov by Sentry. |
Added another condition to check if matchee topic's fragments length is less than the length of base topic's fragment. Currently there's only one condition to handle the opposite condition such as if base topic's fragment length is less than matchee fragment length