Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve locale properly #915

Merged
merged 3 commits into from Jun 19, 2019
Merged

Resolve locale properly #915

merged 3 commits into from Jun 19, 2019

Conversation

auxves
Copy link
Contributor

@auxves auxves commented Jun 19, 2019

Short description of what this resolves:

This PR uses locale.json to resolve the locale instead of environmental variables. This leads to better consistency in localizations.

Changes proposed in this pull request:

  • Use locale.json as config for localize.ts

Fixes: #886

How Has This Been Tested?

Tested by changing language and watching as the extension properly localizes it.

Checklist:

shanalikhan
shanalikhan requested changes Jun 19, 2019
View reviewed changes
src/localize.ts Show resolved Hide resolved
@shanalikhan shanalikhan added this to the v3.3.0 milestone Jun 19, 2019
@shanalikhan shanalikhan merged commit 91cb127 into shanalikhan:v3.3.0 Jun 19, 2019
@auxves auxves deleted the get-locale-better branch June 19, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanalikhan shanalikhan shanalikhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@auxves @shanalikhan