Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Korean translation #981

Merged
merged 4 commits into from Jul 31, 2019
Merged

Fix Korean translation #981

merged 4 commits into from Jul 31, 2019

Conversation

ryul1206
Copy link
Contributor

Short description of what this resolves:

  • Fix all Korean translation of package.nls.ko.json.
  • Now the Korean sentences are clear.

Changes proposed in this pull request:

  • package.nls.ko.json

Fixes: Korean translation

Checklist:

@shanalikhan
Copy link
Owner

Have a look in this file:
https://github.com/shanalikhan/code-settings-sync/blob/master/package.nls.zh-cn.json

You will see for some keys , values are starting from Sync: .

You need to maintain structure in that file.

@ryul1206
Copy link
Contributor Author

Oh, I'm sorry. haha. Now I fixed it.
Here is the comparison result of the number of Sync: .

  • package.nls.ko.json: 74 Sync: <- This one.
  • package.nls.zh-cn.json: 74 Sync:
  • package.nls.json: 73 Sync: and 1 Sync : at "cmd.otherOptions.openSettingsPage"

@shanalikhan shanalikhan added this to the v3.4.2 milestone Jul 31, 2019
@shanalikhan
Copy link
Owner

Thanks, I will release it in new version.

package.nls.json: 73 Sync: and 1 Sync : at "cmd.otherOptions.openSettingsPage"

It would be great if you make Sync: instead of Sync : where required

@shanalikhan shanalikhan changed the base branch from master to v3.4.2 July 31, 2019 22:51
@shanalikhan shanalikhan merged commit e6a027b into shanalikhan:v3.4.2 Jul 31, 2019
@ryul1206 ryul1206 deleted the dev/fix-korean branch August 4, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants