Final Project Feedback

[kuldeep23907]

Hi Shane Auerbach – I am Kuldeep, a mentor who is assisting with the grading. Congratulations, your Final Project passed! We'll be approving it on the course itself in a week or two, but here's your feedback in the meanwhile:

Frontend Comments:

• UI is simple but self-explanatory.
• Rinkeby
• Liked that Github pages are used for front-end deployment for a simple MVP.

Testing comments:

• Structured properly using describe stt.
• Good amount of coverage, all scenarios considered. Few could have been skipped but it's good practice to do testing properly.
• Good work on using helper files for making test cases more realistic.

Contract Comments:

• Good work on Smart Contract. The use of modifiers and events is good. Using string takes a lot of storage, so better to use the IPFS plan? Also bytes(_entry).length calculates the correct length of the string? Please check on it once.
• Inheritance and Interfaces and Access control design patterns have been used. Maybe we can use the factory pattern and design the Smart contract again. Imagine each and every What s separate contract in itself with its own functions.
• specific compile pragma and modifier use for validation are the attack patterns mostly used.
• Ownable and Pausable have been used. Advise looking into other Openzeppelin's contracts and libraries.

Overall:

• Good to have either a MetaMask ""Switch Network"" button or an easier way for users to switch or at least not render content before. The same goes for account change.
• UI is simple and works well. Like the way, you have portrayed yourself in the readme file. People learn from their mistakes if they keep trying. Good work overall. Encourage you to learn and develop more.

Hope you enjoyed the learning journey so far and can continue building on this.