Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gerrit up fails to un-draft #21

Closed
fredlebel opened this issue Jun 28, 2016 · 5 comments
Closed

gerrit up fails to un-draft #21

fredlebel opened this issue Jun 28, 2016 · 5 comments

Comments

@fredlebel
Copy link

Pushing draft then following with a gerrit up fails with the following output.

? Topic "AddressBook" was previously saved as a *draft*, are you sure you want to un-draft it? Yes
Pushing to origin (refs/for/master/AddressBook)
remote: Resolving deltas: 100% (7/7)           
remote: Processing changes: refs: 1, done            
To ssh://user@server/repo
! [remote rejected] HEAD -> refs/for/master/AddressBook (no changes made)
error: failed to push some refs to 'ssh://user@server/repo'
gerrit ERROR Error while pushing commit.

Workaround was to amend my commit before trying to upload it.

gerrit version 0.1.0

@shanesmith
Copy link
Owner

Taking a look at the line ! [remote rejected] HEAD -> refs/for/master/AddressBook (no changes made) it seems like the the commit you were trying to push was already in Gerrit

@fredlebel
Copy link
Author

It was already in gerrit but as a draft. I was trying to un-draft it.

@shanesmith
Copy link
Owner

Hmmm I see, either gerrit up should be made smarter or an undraft command should be created...

@fredlebel
Copy link
Author

Right

@shanesmith shanesmith reopened this Nov 3, 2016
@shanesmith
Copy link
Owner

Fixed by 4233f18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants