Update for 2D GEC Reference Cell Validation

[csdechant]

This update will add the following:

• New BCs, tests, and input files based on the following paper: https://doi.org/10.1116/1.579300
• New Tests folder for syntax tests for input files presented at conferences
• Adding class descriptions to previous Zapdos Objects

[cticenhour]

Currently in the middle of a review, but noticed that the current failures are the result of warnings being treated as errors in the Zapdos testing recipe on CIVET. Those need to be corrected before Zapdos will be allowed to build. See https://civet.inl.gov/job/417790/ and https://civet.inl.gov/job/417791/ for more info on the job output.

[cticenhour]

Good work! Most of my comments are clean-up and typo related. A general comment regarding testing -- test blocks can take in the command-line arguments that allow you to make quick changes to the input file using cli_args=. This allows you to have one base input file, that you then modify to test a specific version (over having multiple copies of the same file minus tiny changes). For example, in your Lymberopoulos_with_argon_metastables_2D_At100mTorr_CourseMesh.i Exodiff test, you could have created a test for Lymberopoulos_with_argon_metastables_2D_At100mTorr.i but with the argument cli_args='Mesh/file='GEC_mesh_coarse.msh' that would have modified that line temporarily for the test and used the coarse mesh. It tends to reduce input file clutter while still doing the testing you want.

[csdechant]

I just push the new commit with Casey's requested changes and fixed the CIVET warning for EconomouDielectricBC.C. I think the other warnings were for CRANE kernels. @keniley1 please let me know if you want me to do a pull request to fix those warning (or if I just have to update Zapdos' version of CRANE, if they have already been fixed).

[csdechant]

I also missed one more CIVET for Zapdos that I will fix.

[cticenhour]

Thanks Corey!

[keniley1]

@cticenhour @csdechant
Sorry this took so long, but I've merged the fixes into the master branch at lcpp-org/crane. I hope that fixes everything.

[csdechant]

Mac test failed with error "Automatic scaling requires a PETSc version of 3.9.0 or greater" for the Conference_Syntax_Tests.Lymberopoulos_with_argon_metastables_2D_At1Torr test (which is weird since the course mesh Exodiff version of that test passed. I will just comment out the automatic scaling for that syntax test for now (so Casey can update the website), if no one has any objections.

[lindsayad]

Instead in the tests file for that test put: petsc_version >= ‘3.9.0’ Don’t just comment it out. We want automatic scaling present in whatever test suite supports it.

…

On Oct 29, 2019, at 6:46 PM, csdechant ***@***.***> wrote:  Mac test failed with error "Automatic scaling requires a PETSc version of 3.9.0 or greater" for the Conference_Syntax_Tests.Lymberopoulos_with_argon_metastables_2D_At1Torr test (which is weird since the course mesh Exodiff version of that test passed. I will just comment out the automatic scaling for that syntax test for now (so Casey can update the website), if no one has any objections. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[csdechant]

Thank you for the information. Would I state that outside of the test block? Like:
petsc_version >= ‘3.9.0’
[Tests]
.
.
.
[]

[cticenhour]

No, you'd put it inside the test that you want the condition to apply to. For example:

[Tests]
.
.
.
  [./Lymberopoulos_with_argon_metastables_2D_At1Torr]
    type = RunApp
    input = 'Lymberopoulos_with_argon_metastables_2D_At1Torr.i'
    check_input = True
    method = opt
    petsc_version >= '3.9.0'
  [../]
.
.
.
[]

[lindsayad]

No within the sub-block of whatever test includes automatic scaling

…

On Oct 29, 2019, at 11:37 PM, csdechant ***@***.***> wrote:  Thank you for the information. Would I state that outside of the test block? Like: petsc_version >= ‘3.9.0’ [Tests] . . . [] — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.