Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add a test for a failure applying patch adding file #66

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

shannonbooth
Copy link
Owner

It seems that for this case we are assuming that everything is fine, and will apply the patch even though:

  1. The file already exists! (GNU patch seems to warn for this case)
  2. Even after confirming that we do not mind that the file already exists, we do not detect that there the content in that file should cause that patch to fail.

It seems that for this case we are assuming that everything is fine, and
will apply the patch even though:

 1. The file already exists! (GNU patch seems to warn for this case)
 2. Even after confirming that we do not mind that the file already
    exists, we do not detect that there the content in that file
    _should_ cause that patch to fail.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (749b640) 89.71% compared to head (a649c46) 89.71%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   89.71%   89.71%           
=======================================
  Files          19       19           
  Lines        2033     2033           
  Branches      872      872           
=======================================
  Hits         1824     1824           
  Misses         77       77           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@shannonbooth shannonbooth merged commit f9e893c into main Nov 11, 2023
14 checks passed
@shannonbooth shannonbooth deleted the add-test-for-failing branch February 4, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants