patch: do not issue spurious warning removing a file in dry-run #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
force-pushed
the
remove-file-dry-run
branch
from
f3441e5
to
418532c
Compare
From a c FILE*.
Since dry run was not writing to the output file, the file size was being determined as non-empty. To fix this, simply check for this on the temporary file which has been written to, even on a dry run.
This is no longer needed now that we are using the C FILE* overload of this function.
shannonbooth
force-pushed
the
remove-file-dry-run
branch
from
418532c
to
5ed2694
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 89.69% 89.89% +0.20%
==========================================
Files 19 19
Lines 2048 2049 +1
Branches 874 870 -4
==========================================
+ Hits 1837 1842 +5
+ Misses 77 75 -2
+ Partials 134 132 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dry run was not writing to the output file, the file size was
being determined as non-empty. To fix this, simply check for this on the
temporary file which has been written to, even on a dry run.