Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indexing type for Eigen 3.4 compatibility #2

Merged
merged 1 commit into from Jan 16, 2024

Conversation

andrjohns
Copy link
Contributor

This PR updates your package's C++ to use an integer vector (Eigen::VectorXi) instead of a doubles vector (Eigen::VectorXd) for storing indexing values, otherwise your package will break with the next RcppEigen release.

Let me know if you have any questions, thanks!

@shanpengli shanpengli merged commit e84c56d into shanpengli:master Jan 16, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants