Skip to content
This repository has been archived by the owner on Apr 6, 2021. It is now read-only.

Artifact types #24

Merged
merged 3 commits into from
Sep 28, 2015
Merged

Artifact types #24

merged 3 commits into from
Sep 28, 2015

Conversation

janstenpickle
Copy link
Member

Fixes #18

- add artifact class
- modify rubygem plugin to publish artifacts for each project
@@ -41,6 +41,10 @@ def projects
end
end

def artifacts(*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this should actually be def artifacts(_) as it should only ever take one project to return the artifacts for at a time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -10,5 +13,16 @@ class RubygemPlugin < Plugin
def build_gem
system 'gem build *.gemspec'
end

def artifacts(project)
Dir[File.join(project.path, '*.gemspec')].flat_map do |file|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use project_tree.glob instead.

nathankleyn added a commit that referenced this pull request Sep 28, 2015
@nathankleyn nathankleyn merged commit 78ffb89 into master Sep 28, 2015
@nathankleyn nathankleyn deleted the 18-artifact-types branch September 28, 2015 09:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants