This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
Create template plugin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| source 'https://rubygems.org' | ||
|
|
||
| gemspec | ||
| gem 'shanty', path: '/users/Chris/shanty/shanty' |
There was a problem hiding this comment.
Should remove the path from here, and instead use the Bundler config trick to make it come from local.
gem 'shanty', git: 'https://github.com/shanty/shantytown'Now run this:
bundle config local.shanty ~/shanty/shantyAnd anywhere you have shanty in a Gemfile, when you bundle exec, Bundler will use your local copy instead. Means it works for anybody who is working on this Gem as well.
janstenpickle
force-pushed
the
template-plugin
branch
from
d4fa47d
to
faadbdf
Compare
| provides_projects_containing "**/*.#{PROJECT_EXTENSION}" | ||
|
|
||
| def on_build | ||
| load_data.each do |env, data| |
There was a problem hiding this comment.
I think we should call this something other than env as this shadows the other env. Perhaps template_env?
There was a problem hiding this comment.
oh yeah, missed that
janstenpickle
force-pushed
the
template-plugin
branch
3 times, most recently
from
f7dcd43
to
e7d2fb2
Compare
| end | ||
| end | ||
|
|
||
| RSpec.shared_context('') do |
There was a problem hiding this comment.
This is a mistake, should be removed. We're using the workspace context now.
janstenpickle
force-pushed
the
template-plugin
branch
from
e7d2fb2
to
cacd064
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.