Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptic panic when there are no CSS or no JS files #15

Closed
kenegozi opened this issue Feb 6, 2015 · 1 comment
Closed

cryptic panic when there are no CSS or no JS files #15

kenegozi opened this issue Feb 6, 2015 · 1 comment

Comments

@kenegozi
Copy link
Contributor

kenegozi commented Feb 6, 2015

When train is executed when there are no CSS or no JS files, YUI compressor fails, and the error reporting is unclear:

YUI Compressor error:
...
panic: exit status 1
...
stacktraces, stacktraces everywhere!

suggested solution is to check for len() of []files, skip YUI if 0, and report.
kenegozi added a commit to kenegozi/train that referenced this issue Feb 6, 2015
@kenegozi
Fixes shaoshing#15 - panic when no JS or no CSS files
255c460
@shaoshing
Copy link
Owner

The issues has been fixed. Thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenegozi @shaoshing