Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in the Tree SHAP arXiv paper #25

Open
ihadanny opened this issue Jan 25, 2018 · 1 comment
Open

Typos in the Tree SHAP arXiv paper #25

ihadanny opened this issue Jan 25, 2018 · 1 comment
Labels
paper

Comments

@ihadanny
Copy link

  1. figure 1, left side talks about "married" and "age" features but is captioned with features "cough" and "fever"
  2. Shapely formula in page 17 is wrong, M-|S|!-1 should be (M-|S|-1)!
  3. indexing in EXTEND is broken? first time we call it l=len(m)+1=0+1=1, then we update m[l+1] which is m[2]. is that what you meant?
@slundberg slundberg changed the title typos in the paper Typos in the Tree SHAP arXiv paper Jan 26, 2018
@slundberg
Copy link
Collaborator

Thanks! I'll make sure 1-2 are fixed in an upcoming revision. 3 is bit more complicated but I don't think it is an error. I think the best way to explain would be for me to write up a python example. So I'll post here when I do that. (i'll be out for a few days though so I apologize in advance for the slow answer)

dwolfeu pushed a commit to dwolfeu/shap that referenced this issue May 22, 2023
@connortann
Add ruff linter configuration and precommit hook (shap#25)
dacf022 
* Add minimal Ruff configuration

* Restrict ruff to minimal error set

* Add linter to CI

* Broader selection of rules

* Move linter job to pre-commit

* Fixup end-of-file whitespace

* Code review suggestions

* Revert github action for linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
paper
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ihadanny @slundberg @thatlittleboy