Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaBoost Support #335

Closed
DNCoelho opened this issue Nov 22, 2018 · 5 comments
Closed

AdaBoost Support #335

DNCoelho opened this issue Nov 22, 2018 · 5 comments

Comments

@DNCoelho
Copy link

Hello,

First of all, thank you very much for developing this amazing tool.

I just wanted to ask if there was any plans to add support to AdaBoost as the title implies.
Or if support is not planned and this is not a too great pain in the ass a quick explanation of how one could go about adding it.

Many thanks in advance.

@slundberg
Copy link
Collaborator

Thanks! I don't have plans to add support, but it shouldn't be too hard. TreeExplainer creates a TreeEnsemble object from whatever model type we are trying to explain, and then works with that downstream. So all you would need to do is and add another if statement in the TreeEnsemble constructor similar to the one for gradient boosting: https://github.com/slundberg/shap/blob/4bd41ea9592475370905eadd47f6b4879eeebf49/shap/explainers/tree.py#L433-L443

If you have specific questions let me know and I'll be happy to help.

@DNCoelho
Copy link
Author

Tank you for the quick response!

@maxencebrochard
Copy link

Hi @DNCoelho,

Did you manage to implement Adaboost? If so, would be very interested :)

Thanks

@hdnh2006
Copy link

hdnh2006 commented Apr 8, 2020

I left an answer in this link that surely could help.

@slundberg
Copy link
Collaborator

@hdnh2006 if you added support for AdaBoost to your version please consider a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants