add AdaBoostClassifier #1219
Closed
add AdaBoostClassifier #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!! Could you also add a quick sum check to make sure there are no bugs now or in the future? See this example for the random forest: https://github.com/slundberg/shap/blob/fc30c661339e89e0132f5f89e5385e3681090e1f/tests/explainers/test_tree.py#L605-L619 |
diarmaidfinnerty
added a commit
to diarmaidfinnerty/shap
that referenced
this pull request
Oct 24, 2020
This commit implements the AdaBoostClassifier to the shap/explainers/_tree.py. I have also added the corresponding test_sum_match function in tests/explainers/test_tree.py This is an extension of a previous pull request shap#1219 which was awaiting the test in test_tree.py.
2 tasks
|
We appreciate your contribution! This Pull Request has been inactive for two years, so it's been automatically marked as 'stale'. Please leave a comment if you would still like the PR to remain open, and the 'stale' label will be removed. Otherwise, if there is no activity in the next 90 days the PR will be closed. |
github-actions
bot
added
the
stale
|
This PR has been automatically closed due to a lack of recent activity. We welcome your contributions! If your patch is still relevant, please don't hesitate to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues using AdaBoostClassifier with your package, and came across #335 and this Stack Overflow question and answer. It seemed like the OP never added a pull request, so I figured I'd add it with the updated code that uses
safe_isinstanceinstead.Edits are in lines 598-610 in the
shap/explainers/tree.pyfile.