Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta issue] Release 0.44.1 #3467

Closed
6 tasks done
connortann opened this issue Jan 23, 2024 · 5 comments
Closed
6 tasks done

[Meta issue] Release 0.44.1 #3467

connortann opened this issue Jan 23, 2024 · 5 comments
Assignees
Milestone

Comments

@connortann
Copy link
Collaborator

connortann commented Jan 23, 2024

As suggested by @CloseChoice , let's make a bugfix release for the HTML regression. I suggest aiming to make the release on Thursday.

Checklist:

FYI @shap/shap-maintainers

@connortann connortann added this to the 0.44.1 milestone Jan 23, 2024
@CloseChoice
Copy link
Collaborator

If I can help you with anything here, feel free to ping me and tell me which part you want to get rid of ;)

@connortann
Copy link
Collaborator Author

Thanks! This should be straightforward, not least because we've recently put a lot of effort into getting the release cycle "commit-less": for example, the version number from git tags, the release notes from GitHub PRs, and so on.

I'll plan to make this release myself, but for the purposes of knowledge transfer feel free to look through the contributing guide to get a feel for the steps required.

@connortann connortann self-assigned this Jan 25, 2024
@CloseChoice
Copy link
Collaborator

@connortann hmm, do we need to merge #3518 into the release? Or how can we get this into conda forge? I rerun the CI but think I missed that this #3518 is not included in the 0.44.1 tag. Or maybe it's best if we just close this here and then go straight to 0.45.0 on conda?

@connortann
Copy link
Collaborator Author

Once a release has been made, it is generally much more preferable to create new patch releases rather than overwrite a previous one. So, we could theoretically make a new branch from 0.44.1, add fixes, and release 0.44.2.

However- as I understand, we might be able to fix the conda-forge CI by changing the conda dependencies - i.e., to specify a constraint in recipe.yaml to skip pytorch tests on macos:

https://github.com/conda-forge/shap-feedstock/blob/6d80fedb3126d20c221bee28fe96000f199101c8/recipe/meta.yaml#L66

@connortann
Copy link
Collaborator Author

Hurrah, we (finally) got the conda package deployed for 0.44.1, which was a rather rocky process:
conda-forge/shap-feedstock#76

Hoping the subsequent 0.45.0 will be smoother on conda-forge, now that we have dropped python 3.8 . I think we are starting to see the benefits of adopting SPEC 0 and dropping older versions in a timely manner.

FYI @CloseChoice @DanGolding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants