Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generated ids for html displaying #3464

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

CloseChoice
Copy link
Collaborator

@CloseChoice CloseChoice commented Jan 20, 2024

Overview

Closes #3448
Closes #3431

Description of the changes proposed in this pull request:
Fix ids in force plot code.

A hotfix release 0.44.1 would be great aswell.

Checklist

  • All pre-commit checks pass.
  • [ ] Unit tests added (if fixing a bug or adding a new feature)

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7bd33ff) 59.01% compared to head (edfd2dc) 59.00%.

Files Patch % Lines
shap/plots/_force.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3464      +/-   ##
==========================================
- Coverage   59.01%   59.00%   -0.01%     
==========================================
  Files          89       89              
  Lines       12606    12608       +2     
==========================================
  Hits         7439     7439              
- Misses       5167     5169       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connortann connortann added the bug Indicates an unexpected problem or unintended behaviour label Jan 23, 2024
Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for taking this up! I agree - let's aim to make a hotfix release soon. I'll get on to that this week.

@connortann connortann merged commit 3514504 into shap:master Jan 23, 2024
13 of 15 checks passed
@connortann connortann added this to the 0.44.1 milestone Jan 23, 2024
@connortann connortann mentioned this pull request Jan 23, 2024
6 tasks
@CloseChoice CloseChoice deleted the FIX-html-display-forceplot branch January 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: SHAP force plots HTML is broken (regression) BUG: Force plot JS Not Initialized
2 participants