Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove boston dataset as promised #3316

Merged
merged 1 commit into from Oct 7, 2023
Merged

refactor: remove boston dataset as promised #3316

merged 1 commit into from Oct 7, 2023

Conversation

thatlittleboy
Copy link
Collaborator

Overview

Closes #XXXX

Description of the changes proposed in this pull request:

  • Remove the shap.datasets.boston Boston dataset, which has been marked deprecated since the previous major version 0.42, and slated for removal in 0.43.0.

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@thatlittleboy thatlittleboy added this to the 0.43.0 milestone Oct 7, 2023
@connortann connortann added the BREAKING Indicates that a PR is introducing a breaking change label Oct 7, 2023
connortann
connortann approved these changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@connortann connortann merged commit 3ec6d1d into master Oct 7, 2023
15 checks passed
@connortann connortann deleted the deprecate-boston branch October 7, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connortann connortann connortann approved these changes

Assignees
No one assigned
Labels
BREAKING Indicates that a PR is introducing a breaking change
Projects
None yet
Milestone
0.43.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thatlittleboy @connortann