Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: Tabular prediction Benchmark #3338

Merged

Conversation

znacer
Copy link
Contributor

@znacer znacer commented Oct 14, 2023

Overview

Closes related task in #3036 and #2322

Description of the changes proposed in this pull:
Replace Boston datasets calls that are deprecated by California.

Checklist

@znacer znacer changed the title Replace boston by california Notebook: Tabular prediction Benchmark Oct 14, 2023
@znacer znacer marked this pull request as ready for review October 14, 2023 13:12
@thatlittleboy
Copy link
Collaborator

Seems like the legend and axis labels are missing from the plots now (compare to the notebook on master)

image

v.s. on master

image

@znacer
Copy link
Contributor Author

znacer commented Oct 15, 2023

calculation of auc seems to be made differently than at the time the notebook was created. I will try to work on it within the next few days.

@znacer
Copy link
Contributor Author

znacer commented Oct 19, 2023

@thatlittleboy auc score has been added to figures 😃

@thatlittleboy thatlittleboy added the documentation Relating to readthedocs, notebooks, and exposition in docstrings label Oct 20, 2023
Copy link
Collaborator

@thatlittleboy thatlittleboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@thatlittleboy thatlittleboy merged commit 2ba2b81 into shap:master Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to readthedocs, notebooks, and exposition in docstrings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants