Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update run_notebooks job to show tracebacks #3512

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

connortann
Copy link
Collaborator

@connortann connortann commented Feb 19, 2024

Updates the run_notebooks jobs to show the traceback of any exceptions. This helps debug failing PRs, as the current logs don't seem to show precisely what has failed.

Other minor related change:

  • Sort the lists of notebook paths, might as well
  • Set the CI python version (as "matrix" does not exist in the job)
  • Rename the job from run_tests to run_notebooks

Here's an example run showing the tracebacks in the failing notebooks.

@connortann connortann added this to the 0.45.0 milestone Feb 19, 2024
@connortann connortann added the skip-changelog PRs that should be excluded from the changelog label Feb 19, 2024
@connortann connortann force-pushed the run_notebooks_fail branch 2 times, most recently from 306bd9d to 596bd58 Compare February 19, 2024 15:43
@connortann connortann changed the title Refactor run_notebooks job MAINT: Update run_notebooks job to show tracebacks Feb 19, 2024
@connortann connortann marked this pull request as ready for review February 19, 2024 15:46
Copy link
Collaborator

@CloseChoice CloseChoice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me.

@connortann connortann merged commit 8f63bbd into master Feb 20, 2024
7 checks passed
@connortann connortann deleted the run_notebooks_fail branch February 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog PRs that should be excluded from the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants