Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation warnings to unused functions #3516

Conversation

CloseChoice
Copy link
Collaborator

Overview

Works towards #3507

Description of the changes proposed in this pull request:

  • add deprecation warning for unused code

Checklist

  • All pre-commit checks pass.
  • [ ] Unit tests added (if fixing a bug or adding a new feature)

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (584fb9c) 59.38% compared to head (7de0c4b) 59.37%.

Files Patch % Lines
shap/explainers/_explainer.py 50.00% 1 Missing ⚠️
shap/plots/_text.py 50.00% 1 Missing ⚠️
shap/utils/_masked_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3516      +/-   ##
==========================================
- Coverage   59.38%   59.37%   -0.01%     
==========================================
  Files          90       90              
  Lines       12733    12739       +6     
==========================================
+ Hits         7561     7564       +3     
- Misses       5172     5175       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think before fully removing text_old for example I'd want to fully read through both functions to understand the differences and ensure nothing of value is lost; but in any case raising the warning seems like a good place to start.

@connortann connortann changed the title add deprecation warnings add deprecation warnings to unused functions Feb 23, 2024
@connortann connortann added the enhancement Indicates new feature requests label Feb 23, 2024
@connortann connortann merged commit 8caf18a into shap:master Feb 23, 2024
14 of 16 checks passed
@CloseChoice CloseChoice deleted the REF-add-deprecation-warnings-to-unused-code branch February 23, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants