Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Prototype new plotting API for bar plot, accept and return axes #3523
ENH: Prototype new plotting API for bar plot, accept and return axes #3523
Changes from 12 commits
d9a7b9a
39936f4
10e4cff
a4746d1
2e65b4b
3c87705
7322a7e
ecd063f
d8b4bee
25f1f18
896e3c9
1fc37d2
3a7bb45
231ff37
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check warning on line 119 in shap/plots/_bar.py
Codecov / codecov/patch
shap/plots/_bar.py#L119
Check warning on line 127 in shap/plots/_bar.py
Codecov / codecov/patch
shap/plots/_bar.py#L127
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is one functional change that I needed to make in order to reproduce more closely the plots in the API example notebook.
In the API example notebook, many plots have show_data=True. This adds the small grey numbers on the left axis. It looks like this behaviour was then changed at some point to only show data values when there are no transforms applied.
However, I think
show_data
still makes sense asTrue
for a single explanation when the only operation applied has been__getitem__
.Before (show_data = False)
After (show_data = True)