Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upcast array to solve njit failure #3652

Merged
merged 2 commits into from
May 14, 2024
Merged

upcast array to solve njit failure #3652

merged 2 commits into from
May 14, 2024

Conversation

CloseChoice
Copy link
Collaborator

Overview

Closes #3651

Description of the changes proposed in this pull request:

  • upcast float16 arrays before handing them over to njit function since f16 does not seem to be supported by njit functions

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

connortann
connortann approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and great that you always add good tests 👍

@connortann connortann merged commit e21d70f into shap:master May 14, 2024
14 checks passed
@CloseChoice CloseChoice deleted the FIX-njit-failure-masked-model branch May 14, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connortann connortann connortann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Failed in nopython mode pipeline (step: native lowering) float16
2 participants
@CloseChoice @connortann