-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh support tf216 keras3 #3677
Enh support tf216 keras3 #3677
Conversation
@connortann : I remember we had this error before while package installation: ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
unknown package:
Expected sha256 d7599b65c7af7abbc978dbf345712c60fd596aa5670496561cc10e8a71cebfb2
Got 1f3afff1ebaea3408018256dccf958cd167e3815cfab29253155063ee7ac51c5 What was the solution? Removing the current caches? On a side note: do we have more than 10GB cache size: https://github.com/shap/shap/actions/caches (see |
As I recall, that issue was just a transient network issue. Re-running the CI job seemed to fix the issue and the downloaded packages matched the expected hashes. Regarding cache size, yes I think we might approach or occasionally exceed that limit. I remember doing a fair bit of trial-and-error trying to determine which packages could be cached by pip on CI, without exceeding the total limit. My notes from that experimentation are here: As per that thread, we decided to cache only a couple of packages, aiming to keep each cache under 2GB total so that the total 10GB cache. This was then implemented here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Over to you to merge when ready.
Co-authored-by: connortann <71127464+connortann@users.noreply.github.com>
@connortann Thanks for the review. Will merge on green. |
Overview
Closes #3645
Description of the changes proposed in this pull request:
Checklist