Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enh support tf216 keras3 #3677

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Enh support tf216 keras3 #3677

merged 11 commits into from
Jun 11, 2024

Conversation

CloseChoice
Copy link
Collaborator

@CloseChoice CloseChoice commented Jun 1, 2024

Overview

Closes #3645

Description of the changes proposed in this pull request:

  • updated tests to work with keras3 + tensorflow 2.16

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@CloseChoice CloseChoice marked this pull request as ready for review June 7, 2024 09:58
@CloseChoice
Copy link
Collaborator Author

CloseChoice commented Jun 7, 2024

@connortann : I remember we had this error before while package installation:

 ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
    unknown package:
        Expected sha256 d7599b65c7af7abbc978dbf345712c60fd596aa5670496561cc10e8a71cebfb2
             Got        1f3afff1ebaea3408018256dccf958cd167e3815cfab29253155063ee7ac51c5

What was the solution? Removing the current caches?

On a side note: do we have more than 10GB cache size: https://github.com/shap/shap/actions/caches (see Approaching total cache storage limit (14.48 GB of 10 GB Used))?

@connortann
Copy link
Collaborator

As I recall, that issue was just a transient network issue. Re-running the CI job seemed to fix the issue and the downloaded packages matched the expected hashes.

Regarding cache size, yes I think we might approach or occasionally exceed that limit. I remember doing a fair bit of trial-and-error trying to determine which packages could be cached by pip on CI, without exceeding the total limit. My notes from that experimentation are here:

dsgibbons#42 (comment)

As per that thread, we decided to cache only a couple of packages, aiming to keep each cache under 2GB total so that the total 10GB cache. This was then implemented here:

dsgibbons#84

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Over to you to merge when ready.

pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: connortann <71127464+connortann@users.noreply.github.com>
@CloseChoice
Copy link
Collaborator Author

@connortann Thanks for the review. Will merge on green.

@CloseChoice CloseChoice merged commit 8c8ee84 into master Jun 11, 2024
14 checks passed
@CloseChoice CloseChoice deleted the ENH-support-tf216-keras3 branch June 11, 2024 15:20
@CloseChoice CloseChoice mentioned this pull request Jun 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: 'tuple' object has no attribute 'as_list'
2 participants